Starting navigation sends route retrieval performance event#1954
Starting navigation sends route retrieval performance event#1954
Conversation
Cartfile
Outdated
There was a problem hiding this comment.
Ideally we’ll release MapboxDirections.swift v0.27.0 shortly before landing this PR. We’ll also need to update all three podspecs and the CocoaPods installation test’s podfiles to require the new release.
There was a problem hiding this comment.
This is just to demonstrate how we’d go about collecting analogous statistics about client-side route calculation if that were to become relevant in the future.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Never mind, we decided against storing the counters and attributes as flat dictionaries.
There was a problem hiding this comment.
This is measured in seconds (as a floating-point number), but mapbox/mapbox-navigation-android#1661 implemented the field in nanoseconds as a long integer.
There was a problem hiding this comment.
1ec5
force-pushed
the
1ec5-event-route-retrieval
branch
2 times, most recently
from
32846bf to
0bbee95
Compare
Send a route retrieval performance event, indicating how long a round-trip to the Directions API takes, when starting a navigation service (i.e., when starting navigation or getting rerouted).
This reverts commit 50593ae03a8293ee581c34dad642806474a66d1c.
1ec5
force-pushed
the
1ec5-event-route-retrieval
branch
from
0bbee95 to
0576575
Compare
2 participants
Send a route retrieval performance event, indicating how long a round-trip to the Directions API takes, when starting a navigation service (i.e., when starting navigation or getting rerouted). Instead of a single EventDetails class, now there are NavigationEventDetails and PerformanceEventDetails classes that share an EventDetails protocol.
This is a counterpart to mapbox/mapbox-navigation-android#1661 on Android that depends on mapbox/mapbox-events-ios#93 and mapbox/mapbox-directions-swift#335.
/cc @mapbox/navigation-ios @devotaaabel @rclee